Gen 5 is my favorite because the game adds character customization. Being able to play yourself in the Pokémon world makes it that much more immersive.
Gen 4 is a close second because splitting move types into physical and special according to the kind of attack (Ice Punch vs Ice Beam) instead of the type of attack (Fighting vs Water) changed the meta in a good way.